Use a struct for ClientContext (fix #169) #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the string-based ClientContext implementation with strongly-typed structs to provide better type safety and compiler error detection for AWS Lambda runtime client context data.
- Replaces
String?type with structuredClientContextandClientApplicationtypes - Adds proper JSON encoding/decoding with snake_case field mapping for AWS compatibility
- Includes comprehensive unit tests covering various ClientContext scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/AWSLambdaRuntime/LambdaContext.swift | Introduces ClientContext and ClientApplication structs with proper Codable implementation and updates LambdaContext to use the new types |
| Tests/AWSLambdaRuntimeTests/LambdaContextTests.swift | Adds comprehensive test suite covering JSON encoding/decoding scenarios for the new ClientContext types |
sebsto
added
⚠️ semver/major
ktoso
reviewed
Aug 4, 2025
ktoso
approved these changes
Aug 4, 2025
Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use a String for Lambdacontext.ClientContext, use a struct instead
fix for #169
Note: this PR introduces an API change that will break function using
LambdaContext, we should integrate this change during the beta otherwise it will require a major version bump.Motivation:
Let the compiler detect type errors for us
Modifications:
Result:
No more String?